Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes TestE2ESimple failure by ensuring positive initial stake for validator #3234

Merged
merged 10 commits into from
Apr 2, 2024

Conversation

staheri14
Copy link
Contributor

@staheri14 staheri14 commented Apr 1, 2024

Closes #3233
It sets the half of the initial token as the stake.

@staheri14 staheri14 self-assigned this Apr 1, 2024
@staheri14 staheri14 added fix testing items that are strictly related to adding or extending test coverage labels Apr 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://celestiaorg.github.io/celestia-app/pr-preview/pr-3234/
on branch gh-pages at 2024-04-01 21:45 UTC

@staheri14 staheri14 changed the title fix: fizes TestE2ESimple failure by ensuring positive initial stake for validator fix: fixes TestE2ESimple failure by ensuring positive initial stake for validator Apr 1, 2024
@staheri14 staheri14 marked this pull request as ready for review April 1, 2024 22:41
Copy link
Contributor

coderabbitai bot commented Apr 1, 2024

Walkthrough

The update involves enhancing the GenesisValidator method in the Node structure to initialize the Stake field to half of the SelfDelegation amount. This modification aims to address a bug where the absence of an initial stake for a validator caused the TestE2ESimple test to fail, ensuring validators have a positive stake from the outset.

Changes

File(s) Change Summary
test/e2e/node.go Added initialization of Stake to half of SelfDelegation in GenesisValidator.

Assessment against linked issues

Objective Addressed Explanation
#3233: Ensure validators have a positive initial stake in TestE2ESimple

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@staheri14
Copy link
Contributor Author

Linter issue should be gone after merging this PR.

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@celestia-bot celestia-bot requested review from a team, ramin and rach-id and removed request for a team April 2, 2024 15:24
@celestia-bot celestia-bot requested a review from a team April 2, 2024 15:26
@staheri14 staheri14 enabled auto-merge (squash) April 2, 2024 15:31
@staheri14 staheri14 merged commit 90a5d2d into main Apr 2, 2024
33 checks passed
@staheri14 staheri14 deleted the sanaz-set-initial-stake-e2e-test branch April 2, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestE2ESimple Fails Due to Missing Initial Stake for Validator
5 participants