Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: migrate to new square version #3742

Merged
merged 8 commits into from
Aug 7, 2024
Merged

chore!: migrate to new square version #3742

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7bad5ea
chore!: migrate to new square version
cmwaters Jul 26, 2024
c11731d
make more fixes
cmwaters Aug 1, 2024
1235a0d
fix remaining tests
cmwaters Aug 6, 2024
792b208
Merge branch 'main' into cal/integrate-square-v2
cmwaters Aug 6, 2024
7f43c2b
resolve merge conflicts
cmwaters Aug 6, 2024
226a98c
resolve comments
cmwaters Aug 6, 2024
ff2f864
Update specs/src/specs/namespace.md
rootulp Aug 6, 2024
e837547
Merge branch 'main' into cal/integrate-square-v2
cmwaters Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions proto/celestia/core/v1/blob/blob.proto
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion specs/src/specs/namespace.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Among the potential consequences is the _Woods Attack_, as elaborated in this fo
## Implementation

See the [namespace implementation in go-square](https://github.com/celestiaorg/go-square/v2/share/be3c2801e902a0f90f694c062b9c4e6a7e01154e/namespace/namespace.go).
For the most recent version, which may not reflect the current specifications, refer to [the latest namespace code](https://github.com/celestiaorg/go-square/v2/share/main/share/namespace.go).
For the most recent version, which may not reflect the current specifications, refer to [the latest namespace code](https://github.com/celestiaorg/go-square/main/share/namespace.go).
rootulp marked this conversation as resolved.
Show resolved Hide resolved

## Go Definition

Expand Down
2 changes: 1 addition & 1 deletion specs/src/specs/shares.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ Share splitting is the process of converting a blob into a share sequence. The p

## Implementation

See [go-square/shares](https://github.com/celestiaorg/go-square/v2/tree/be3c2801e902a0f90f694c062b9c4e6a7e01154e/shares).
See [go-square/shares](https://github.com/celestiaorg/go-square/tree/be3c2801e902a0f90f694c062b9c4e6a7e01154e/shares).

## References

Expand Down
4 changes: 2 additions & 2 deletions x/blob/ante/blob_share_decorator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func TestBlobShareDecorator(t *testing.T) {
{
name: "PFB with many single byte blobs should fit",
pfb: &blob.MsgPayForBlobs{
// 4095 blobs each of size 1 byte should occupy 4095 share.
// 4095 blobs each of size 1 byte should occupy 4095 shares.
// When square size is 64, there are 4095 shares available to
// blob shares so we don't expect an error for this test case.
BlobSizes: repeat(4095, 1),
Expand All @@ -93,7 +93,7 @@ func TestBlobShareDecorator(t *testing.T) {
{
name: "PFB with too many single byte blobs should not fit",
pfb: &blob.MsgPayForBlobs{
// 4096 blobs each of size 1 byte should occupy 4096 share.
// 4096 blobs each of size 1 byte should occupy 4096 shares.
// When square size is 64, there are 4095 shares available to
// blob shares so we expect an error for this test case.
BlobSizes: repeat(4096, 1),
Expand Down
4 changes: 2 additions & 2 deletions x/blob/client/cli/payforblob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ import (

const (
// FlagShareVersion allows the user to override the share version when
// submitting a PayForshare.
// submitting a PayForBlob.
FlagShareVersion = "share-version"

// FlagNamespaceVersion allows the user to override the namespace version when
// submitting a PayForshare.
// submitting a PayForBlob.
FlagNamespaceVersion = "namespace-version"

// FlagFileInput allows the user to provide the path to a JSON file for
Expand Down
Loading