fix: make check-bbr #4004
fix: make check-bbr #4004
Conversation
evan-forbes
requested review from
rootulp and
ninabarbakadze
and removed request for
a team
evan-forbes
requested review from
cmwaters and
rach-id
and removed request for
a team
📝 Walkthrough📝 Walkthrough📝 Walkthrough📝 WalkthroughWalkthroughThe changes include updates to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
docs/release-notes/release-notes.md (1)
10-10: LGTM with a minor formatting suggestion.The added instructions for BBR configuration are clear and accurate. However, for consistency with other bullet points in the document, consider capitalizing the first word.
- - if using linux in docker, kubernetes, a vm or baremetal, this can be done by calling the `make enable-bbr` command on the host machine. + - If using Linux in Docker, Kubernetes, a VM or bare metal, this can be done by calling the `make enable-bbr` command on the host machine.README.md (1)
Line range hint
87-94: Consider adding a note about system requirements.While the instructions are clear, it would be helpful to explicitly mention that BBR configuration requires root/sudo access and is primarily for Linux systems. This could prevent confusion for users on other operating systems.
Consider adding a note like:
If not, enable it on Linux by calling the `make enable-bbr` or by running: + > Note: These commands require root/sudo access and are specific to Linux systems.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (3)
- Makefile (1 hunks)
- README.md (1 hunks)
- docs/release-notes/release-notes.md (1 hunks)
🧰 Additional context used
🔇 Additional comments (2)
README.md (1)
87-87: LGTM! Clear and consistent command update.The change from
make use-bbrtomake enable-bbris well documented and provides both the make command and manual steps for users who need to enable BBR congestion control.Makefile (1)
254-257: LGTM! Fixed Makefile variable substitution syntax.The change correctly escapes the awk variable
$3to$$3in the Makefile context. This is necessary because Make interprets single$as its own variable reference, while we want to pass the literal$3to the awk command. The fix ensures that the BBR congestion control algorithm check works as intended.
evan-forbes
dismissed stale reviews from rach-id and cmwaters
The base branch was changed.
evan-forbes
added
the
backport:v2.x
## Overview very minor fix that fixes the `check-bbr` command (cherry picked from commit c410d88) # Conflicts: # Makefile
## Overview very minor fix that fixes the `check-bbr` command <hr>This is an automatic backport of pull request #4004 done by [Mergify](https://mergify.com). --------- Co-authored-by: Evan Forbes <[email protected]> Co-authored-by: evan-forbes <[email protected]>
Overview
very minor fix that fixes the
check-bbrcommand