fix(ci): make the Pulp delivery and promotion jobs blocking

[kduret]

Centreon team (internal PR)

Description

The Pulp delivery and promotion steps of the deliver-packages-pulp job were made non-blocking during the Artifactory-to-Pulp migration: continue-on-error: true on the job and on the package-delivery-pulp / promote-to-stable-pulp steps, plus a Warn if the Pulp delivery failed step turning the failure into a ::warning::. The job stayed green whatever happened, so Pulp failures went unnoticed (on the 25.10 branches of the product monorepos, nothing reached Pulp for days before anyone saw it, MON-209523).

This PR drops the continue-on-error flags and the warning step, so a Pulp error fails the job (and check-status) exactly like an Artifactory error does. The if guards deciding when the delivery or the promotion runs are unchanged. Same change on the centreon, centreon-collect and centreon-modules workflows under MON-209532.

Fixes MON-209532

Type of change

• Patch fixing an issue (non-breaking change)
• New functionality (non-breaking change)
• Functionality enhancement or optimization (non-breaking change)
• Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Every touched workflow was parsed and linted. On a delivery run of this branch, the deliver … on pulp job now shows the real conclusion: green when Pulp accepted the packages, red (and check-status red) when the Pulp step fails, with no Pulp delivery/promotion failed warning anymore.

Checklist

• I have followed the coding style guidelines provided by Centreon
• I have commented my code, especially hard-to-understand areas of the PR.
• I have rebased my development branch on the base branch (develop).
• I have provide data or shown output displaying the result of this code in the plugin area concerned. (workflow-only change, no plugin output involved)