Repository navigation
Conversation
The lib and lua-* versions move from workflow literals to .version.<package> (VERSION/RELEASE), so a version change is visible outside the CI files.
Connectors take .version.stream-connectors (YYYYMMNN) instead of the build date: builds of a release share its number and same-day rebuilds no longer collide.
A workflow whose only changes since the previous release tag are under .github/ is skipped; versions are bumped in the root version files.
release-new fails before any write when the content of a package with a root version file changed since the previous release tag but its version file did not.
1 task done
The deb dependency changed from libffi7 | libffi8 to libffi8 (#395) under 0.2.4-2.
Only versioned workflows ignore their ci-only changes (connector dependencies live in stream-connectors.yml), the bump check requires a higher version and fails without yq, and the version steps reject a malformed version file.
2 of 11 tasks
The bump check no longer reads the workflow paths, so it doesn't depend on how the packaging workflows are wired (see #389).
tuntoja
marked this pull request as ready for review
October 6, 2026 16:19
tuntoja
requested review from
kduret,
mushroomempires and
tanguyvda
and removed request for
a team
October 6, 2026 16:19
1 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs MON-205723
Description
Third step, stacked on #409: the fixed package versions move out of the workflow files, so that a higher version, not a CI change, decides what ships.
Root version files in
KEY=valueform (as in centreon), read by a "Get package version" step that rejects a malformed file. Each file is added to its workflow's paths:.version.stream-connectors-libVERSION=3.8.2,RELEASE=1(bumped: add more keywords to params to hide list #380, add new param drop_events_on_send_failure #388 and fix issue when host/service not found in cache when receiving downtime #393 changedsc_event,sc_flushandsc_paramsunder3.8.1).version.lua-cffiVERSION=0.2.4,RELEASE=3(bumped: enh(ci): removing ubuntu from ci (unsupported distro) #395 changed the deb dependency under0.2.4-2).version.lua-base64/-lsqlite3/-openssl/-sql-mysql/-tz1.5.3-1,0.9.7-1,0.11.1-1,2.7.0-1,0.5-1)Upstream source pins (
ref:,LSQLITE3_VERSION) stay in the workflows, so an upstream upgrade edits both files.Connectors are versioned with the release number (
.version.stream-connectors, YYYYMMNN, already checked byrelease-new) instead of the build date.bump-stream-connectors-*PR right after each release, so develop doesn't build the stable number.Tag promotion ignores CI-only changes of the versioned workflows (lib, lua-*): a version bump is what makes them ship.
stream-connectors.ymlstill counts its own changes, because the connectors' dependencies live in it.release-newrefuses a release with an unbumped package, before any write: content changed since the previous release tag without a higher version. For example:content changed since centreon-stream-connectors-20261000 without a higher version: .version.stream-connectors-lib 3.8.2-1 -> 3.8.2-1 (modules/centreon-stream-connectors-lib/sc_flush.lua).release-new.sh, so the check doesn't depend on how workflows are wired (Add triggers for stream connectors #389).20261000.release-newdry run right after cutting the branch to catch it early.Pulp safety net: testing delivery already refuses a version that is in stable (
assert_not_in_stable), so a forgotten bump also fails at build time.First release (
20261000)stream-connectors,stream-connectors-libandlua-cffion the release branch. The 5 other lua-* workflows only changed under.github/and are skipped.git range-diffand force-push), then cutrelease-20261000.stream-connectors.ymlandstream-connectors-lib.yml. Whichever merges first, the tag trigger has to move to its orchestrator, and the lib needs a version above3.8.2. See Add triggers for stream connectors #389 (comment).Type of change
How this pull request can be tested ?
.version.*files and workflow paths;.github/exclusion makes the harnesses fail.20261000, refusal after an unbumped lib change, success after a bump.