Repository navigation
fix(map): regenerate editor bundle for use-resource-name label flip - #275
Merged
Merged
Conversation
PR #274 added the inline-label-edit flag reset to grapheditor/Graph.js but did not regenerate the minified bundles. The editor loads js/app.min.js (embeds load js/integrate.min.js), not the source, so the fix never ran: editing a RESOURCE label left useResourceName on, and the engine overwrote the custom label with the live resource name on the next render (MON-23599 Scenario 4). Apply the same flip in cellLabelChanged to the committed app.min.js and integrate.min.js bundles. The build:webapp (ant) toolchain was not available in this environment, so this is the equivalent targeted change rather than a full regeneration; it can be replaced by a build:webapp regen if preferred. Verified end-to-end against a live Centreon map editor: double-clicking a resource label and changing it now sets useResourceName=false, the Edit data switch reflects OFF, and the custom label persists after save. Refs: MON-23599 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Yassir-BenBOUBKER
approved these changes
Oct 22, 2026
Yassir-BenBOUBKER
left a comment
There was a problem hiding this comment.
from now on it better to merge the fixs with the min files
gfontaineCentreon
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
MON-23599 — Renaming a resource must be taken into account, acceptance Scenario 4: double-clicking a resource label to edit it inline must turn Use Resource Name OFF and keep the typed label.
PR #274 added that flag reset to
grapheditor/Graph.js(Graph.prototype.cellLabelChanged), but did not regenerate the minified bundles. The editor loadsjs/app.min.js(and embeds loadjs/integrate.min.js), not thegrapheditor/source — so the fix never executed. Editing a RESOURCE label leftuseResourceName="true", and the engine overwrote the custom label with the live resource name on the next render.This is the same gap noted by #252 / #234, which regenerated bundles via
build:webappalongside their source edits.Change
Apply the same one-line flip inside the minified
cellLabelChangedof the two bundles that carry theGraphoverride:src/main/webapp/js/app.min.js(loaded by the editor)src/main/webapp/js/integrate.min.js(embed/integration build)This mirrors the already-merged
Graph.jschange exactly (setuseResourceNametofalseon the cloned value node when a RESOURCE label is edited by hand).Test
Verified end-to-end against a live Centreon map editor (local engine + develop web), after loading these patched bundles:
useResourceName: true(default ON).useResourceNameflips tofalse.Reproduced the pre-fix failure on a clean develop build (unpatched
app.min.js) to confirm the gap, then confirmed these bundles resolve it.Downstream
After merge, bump
@centreon/drawioincentreon-map/web(pnpm-lock.yaml) to this commit so the deployed editor picks it up.Refs: MON-23599
🤖 Generated with Claude Code