cleanup: remove unneeded updateSnapshotDetails() function
#4840
Conversation
|
@Mergifyio queue |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
Something isn't right here... Maybe the ImageID of the snapshot/parent should not get updated? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
`updateSnapshotDetails()` just calls `getImageInfo()` on an `rbdVolume` created from the `rbdSnapshot`. `getImageInfo()` is a function of the base `rbdImage` struct, so there really is no need for this indirection. Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
rbd/getImageInfo
branch
from
414118a
to
412365e
Compare
mergify
bot
dismissed stale reviews from Rakshith-R and iPraveenParihar
Pull request has been modified.
Both `rbdVolume.repairImageID()` and `rbdVolume.storeImageID()` do the same thing. `repairImageID()` includes optional extra checking for an already set ImageID, which is not part of `storeImageID()`. Remove some unneeded `ImageID == ""` checking because `repairImageID()` does that, and remove the `storeImageID()` function. Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
rbd/getImageInfo
branch
from
412365e
to
ddd41d3
Compare
updateSnapshotDetails()just callsgetImageInfo()on anrbdVolumecreated from the
rbdSnapshot.getImageInfo()is a function of thebase
rbdImagestruct, so there really is no need for this indirection.