Expose csi sidecar metrics for cephfs, rbd and nfs #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
requested changes
Oct 4, 2024
Nikhil-Ladha
force-pushed
the
expose-csi-sidecar-metrics
branch
3 times, most recently
from
af3aa26
to
2d3010e
Compare
nixpanic
reviewed
Oct 4, 2024
charts/ceph-csi-cephfs/values.yaml
Outdated
| @@ -214,6 +214,11 @@ provisioner: | |||
| ## https://github.com/kubernetes-csi/external-provisioner#command-line-options | |||
| extraArgs: [] | |||
|
|
|||
| args: | |||
| # httpEndpoint enables the http server for diagnostics, | |||
| # health checks and metrics | |||
There was a problem hiding this comment.
Maybe also mention that not providing the option disables it?
There was a problem hiding this comment.
IMO we should not have it enabled but disable by default (commenting the port) and let the user enable it when required
There was a problem hiding this comment.
Disabled the option by default, and added a comment mentioning how to enable it.
nixpanic
approved these changes
Oct 4, 2024
nixpanic
added
ci/skip/multi-arch-build
nixpanic
requested changes
Oct 4, 2024
There was a problem hiding this comment.
oh, it seems you've missed the documentation in the README at https://github.com/ceph/ceph-csi/tree/devel/charts/ceph-csi-rbd, and for cephfs too.
Madhu-1
reviewed
Oct 7, 2024
charts/ceph-csi-cephfs/values.yaml
Outdated
| @@ -214,6 +214,11 @@ provisioner: | |||
| ## https://github.com/kubernetes-csi/external-provisioner#command-line-options | |||
| extraArgs: [] | |||
|
|
|||
| args: | |||
| # httpEndpoint enables the http server for diagnostics, | |||
| # health checks and metrics | |||
There was a problem hiding this comment.
IMO we should not have it enabled but disable by default (commenting the port) and let the user enable it when required
Nikhil-Ladha
force-pushed
the
expose-csi-sidecar-metrics
branch
3 times, most recently
from
ecbf689
to
12a8986
Compare
|
Sample truncated output for Sample output for Sample truncated output for Sample truncated output for |
|
Also, updated the PR descrition to include the documentation links for each sidecar to add the |
nixpanic
reviewed
Oct 9, 2024
nixpanic
requested changes
Oct 9, 2024
Nikhil-Ladha
force-pushed
the
expose-csi-sidecar-metrics
branch
from
12a8986
to
f749333
Compare
Can you please also check why we are getting unknown-driver here |
From what I can see from the sidecar code is that intitially when the metrics is initialized the driver name is not provided to the it, later on the driver name is updated in the metrics manager. That's the reason we are initially seeing Same applies for attacher, resizer and snapshotter |
Madhu-1
approved these changes
Oct 10, 2024
nixpanic
approved these changes
Oct 10, 2024
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 81764de |
Expose csi metrics of sidecars deployed by cephfs driver Signed-off-by: Nikhil-Ladha <[email protected]>
Expose csi metrics of sidecars deployed by rbd driver Signed-off-by: Nikhil-Ladha <[email protected]>
Expose csi metrics of sidecars deployed by nfs driver Signed-off-by: Nikhil-Ladha <[email protected]>
Added a release note for csi sidecar metrics Signed-off-by: Nikhil-Ladha <[email protected]>
Nikhil-Ladha
force-pushed
the
expose-csi-sidecar-metrics
branch
from
f749333
to
8ee161b
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Expose CSI sidecar metrics for cephfs, rbd and nfs drivers.
Also, added port definitions in the deployment spec for each container for information/best practice purposes.
Is the change backward compatible?
Maybe, or may not be. Depends on the user, if they have their ports blocked due to security reasons.
Are there concerns around backward compatibility?
None.
But, if the user wants to access the sidecar metrics they need to make sure that the ports are not blocked by firewall in their cluster.
Documentation of each sidecar for enabling the httpEndpoint:
Related issues
Fixes: #881
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)