Fixes related to flatten operation in PVC restored from snapshot #4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CephCSI should not flatten image that can be mounted for use by the user. `checkFlatten()` was called in a recovery code flow of PVC restored from snapshot and was missed while refractoring in ceph#2900 refer: ceph#2900 Signed-off-by: Rakshith R <[email protected]>
During PVC-PVC clone creation, parent of the datasource image is flattened after checking for clone depth. We need to account for data source image as well since we're calculating depth from the parent image. depthToAvoidFlatten = 3(datasource image + temp + final clone) Signed-off-by: Rakshith R <[email protected]>
Rakshith-R
force-pushed
the
fix-flatten
branch
from
a08188c
to
7515ae2
Compare
|
/test ci/centos/mini-e2e/k8s-1.30 |
nixpanic
approved these changes
Nov 14, 2024
|
@Rakshith-R is this fixing known bugs, and should this therefor get backported? |
No, there's no bugs/ issues raised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
CephCSI should not flatten image that can be mounted
for use by the user.
checkFlatten()was called in a recovery code flowof PVC restored from snapshot and was missed while
refractoring in #2900
refer: #2900
During PVC-PVC clone creation, parent of the datasource
image is flattened after checking for clone depth.
We need to account for data source image as well since
we're calculating depth from the parent image.
depthToAvoidFlatten = 3(datasource image + temp + final clone)
Signed-off-by: Rakshith R [email protected]
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)