-
Notifications
You must be signed in to change notification settings - Fork 311
Severity field in IDF #2575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Severity field in IDF #2575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- missing documentation in
docs/user/event.md - missing documentation in
NEWS.md
|
Upgrade function in |
|
@sebix What would you like to add to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks
|
@aaronkaplan Do you want to review this before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renameing v341 -> v342
|
Rebased on develop, but the version numbers in the upgrade function makes no sense |
|
okay, @sebix would it be a disaster if we leave the ver numbers now as is and merge? |
kind of, yes. the version numbers are used by the upgrade function in intelmqctl, which writes the numbering and function names to the state file. leaving wrong numbers where would lead to confusion in the support and when debugging stuff |
|
@aaronkaplan this PR is waiting for your approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. I wonder if we should not document it also in docs.
And here is the definiton that shadowserver has:
critical (typically for highly critical vulnerabilities that are being actively exploited, where failure to remediate poses a very high likelyhood of compromise. typically for RCE or changing or extracting sensitive data)
high (end of life systems, internal systems that you can log into with authentication that are meant to be internal (SMB, RDP), some data can be leaked. Drones/sinkhole events end up in this category)
medium (risk of participating in DDoS, unencrypted services requiring login, vulnerabilities requiring MITM to exploit, attacker will need to know internal systems/infrastructure in order to exploit it)
low (deviation from best practice - little to no practical way to exploit, but setup is not ideal)
info (Informational only, no concerns whatsoever)
All possible fields of an event are documented in https://docs.intelmq.org/latest/user/event/ It is generated at doc build time. I added the severity level explanations/examples to the Result:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Severity is expected in IntelMQ for a long time and partially, it's already used by e.g. ShadowServer reports. This implementation is based on their understanding of the field, but with explicit mentioning that operators could adjust it based on their knowledge. This is not intended to be an ultimate severity classification, but a help for first triage of recived events. Close certtools#2365
Co-authored-by: Sebastian <[email protected]>
update first noninteractive apt call

Severity is expected in IntelMQ for a long time and partially, it's already used by e.g. ShadowServer reports. This implementation is based on their understanding of the field, but with explicit mentioning that operators could adjust it based on their knowledge.
This is not intended to be an ultimate severity classification, but a help for first triage of received events.
As the topic has already been discussed in #2365, I do not open a separated IEP for that. The discussion didn't have a clear outcome, but since then the severity information from Shadowserver has already been implemented and is in use by at least some IntelMQ instances. Implementing it in the default IDF helps wider adoption and prioritisation.
Compatibility: as no bot uses the field by default at the moment, there is no incompatibility risk if the local operator uses modified IDF schema or stores all data in e.g. SQL database. To prevent issues, until the next major release the official bots using the field should fall back to
extra.<field name>if the field does not exist in the local IDF.Close #2365