Skip to content

Conversation

faria-s
Copy link

@faria-s faria-s commented Nov 14, 2024

Improve the design of both show and index partners pages index

2024-11-25_23:46:06
2024-12-02_18:48:08

TODO:

  • improve index page design
  • improve show page design
  • Set gradient colors to vary according to avatar colors

FIX:

  • Fix not being able to remove avatar
  • Fix window resizing responsiveness

@faria-s faria-s linked an issue Nov 14, 2024 that may be closed by this pull request
1 task
@faria-s faria-s self-assigned this Nov 14, 2024
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please align edit partner with the partner title
image

@MarioRodrigues10
Copy link
Member

I also suggest we delay this a bit since #538 is about to be merged and can be used on this page ! 🙌

@MarioRodrigues10
Copy link
Member

Please also solve the conflicts !

Copy link
Contributor

@AfonsoMartins26 AfonsoMartins26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ou need to merge with develop, and then update the image uploader in partner_live/form_component.ex to use the new format. Replace the existing component:

            <.live_component module={ImageUploader} id="uploader" uploads={@uploads} target={@myself} />

to this:

            <.image_uploader id="uploader" upload={@uploads.image} class="h-32 w-full border border-zinc-300 shadow-sm xl:h-64" image_class="h-32 w-full object-cover xl:h-64" />

Once that’s done, everything should work as expected.

@gxnca gxnca requested a review from AfonsoMartins26 July 4, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve index and show partners pages design
4 participants