-
Notifications
You must be signed in to change notification settings - Fork 7
feat: improve index and show partners pages design #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also suggest we delay this a bit since #538 is about to be merged and can be used on this page ! 🙌 |
Please also solve the conflicts ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ou need to merge with develop, and then update the image uploader in partner_live/form_component.ex to use the new format. Replace the existing component:
<.live_component module={ImageUploader} id="uploader" uploads={@uploads} target={@myself} />
to this:
<.image_uploader id="uploader" upload={@uploads.image} class="h-32 w-full border border-zinc-300 shadow-sm xl:h-64" image_class="h-32 w-full object-cover xl:h-64" />
Once that’s done, everything should work as expected.
Improve the design of both show and index partners pages index
TODO:
FIX: