Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: email styling #567

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

feat: email styling #567

wants to merge 8 commits into from

Conversation

RicoPleasure
Copy link
Contributor

@RicoPleasure RicoPleasure commented Mar 3, 2025 •
edited
Loading

Closes #544

@RicoPleasure RicoPleasure changed the title chore: update branch feat: email styling Mar 3, 2025
joaodiaslobo
joaodiaslobo requested changes Mar 15, 2025
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing out your PR, I've realized that the collaborator request emails simply aren't being sent properly.
In department_emails.ex you can notice an emails argument that isn't being used correctly during the sending process. Can you fix this? Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaodiaslobo joaodiaslobo Awaiting requested review from joaodiaslobo

Requested changes must be addressed to merge this pull request.

Assignees

@LeandroCarvalho200409 LeandroCarvalho200409

@RicoPleasure RicoPleasure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style emails
3 participants
@RicoPleasure @joaodiaslobo @LeandroCarvalho200409