DEBUG: Do not override options from --enable-debug #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because they actually produce binaries that can be debugged.
|
Thank you for submitting a pull request! Maybe @Lex-2008 can review this? |
Lex-2008
approved these changes
Feb 26, 2021
|
I wonder if we should actually merge this. The resulting packages and binaries are much bigger, but do we need to care? |
|
yeah, we do care for nightly and pr-pipeline builds, 'cause we're paying for traffic. Do I understand it right that it will affect our nightlies and pr-pipelines? Can we make it optional - like "super-debug" builds? |
Yeah, we could do something like that. But that's a lot more work than just creating a simple PR like this and including it in a build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because they actually produce binaries that can be debugged.