Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1583 - company received date filter fixes #557

Closed
wants to merge 2 commits into from

Conversation

flacoman91
Copy link
Contributor

@flacoman91 flacoman91 commented Nov 1, 2024

fixing company received date filter

This filter was not clearing when you attempt to clear it, either by clicking Clear in the date picker, or clicking "Clear all filters"

Additions

  • added action to clear the filter

Removals

  • removed some convoluted logic where we were trying to be clever and reuse the same action for different filters

Changes

Testing

  • yarn start
  • Add dates to the "The date the CFPB sent the complaint to the company" filter
  • see dates get applied
Screenshot 2024-11-01 at 2 44 42 PM
  • Click Clear in each date to confirm the date can be cleared

Also Click "Clear all filters" to clear out the Company received date filter

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

fixing company received date filter

linting
@flacoman91 flacoman91 force-pushed the DATAP-1583-company-received-filter-fix branch from 734be86 to 0c58445 Compare November 1, 2024 22:28
@cdmh219 cdmh219 self-requested a review November 7, 2024 14:03
@cdmh219 cdmh219 added this pull request to the merge queue Nov 7, 2024
@flacoman91 flacoman91 removed this pull request from the merge queue due to the queue being cleared Nov 7, 2024
@flacoman91 flacoman91 added this pull request to the merge queue Nov 7, 2024
@flacoman91 flacoman91 removed this pull request from the merge queue due to the queue being cleared Nov 7, 2024
@flacoman91 flacoman91 added this pull request to the merge queue Nov 7, 2024
@flacoman91 flacoman91 removed this pull request from the merge queue due to a manual request Nov 7, 2024
@flacoman91 flacoman91 added this pull request to the merge queue Nov 7, 2024
@flacoman91
Copy link
Contributor Author

Merged manually bc merge queue is hanging

@flacoman91 flacoman91 closed this Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a manual request Nov 7, 2024
@flacoman91 flacoman91 deleted the DATAP-1583-company-received-filter-fix branch November 7, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants