Skip to content

Commit

Permalink
Remove unused Lighthouse results upload
Browse files Browse the repository at this point in the history
A nightly GitHub Action runs Lighthouse against the Design System
documentation site, to ensure that it meets with accessibility
guidelines.

Currently this Action is generating a warning message, for example [0]:

> No files were found with the provided path: .lighthouseci.
> No artifacts will be uploaded.

This warning occurs because the upload step can't find the Lighthouse
results.

We don't actually use the raw Lighthouse results in any way; as part of
the nightly test, HTML reports are uploaded to temporary Google storage
and their public URLs are included in the Action log.

Thus there's no need to upload the raw run results. This commit removes
the upload step, thus fixing the warning.

[0] https://github.com/cfpb/design-system/actions/runs/11524988694
  • Loading branch information
chosak committed Oct 28, 2024
1 parent c44259b commit 0fae44b
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/lighthouse.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,3 @@ jobs:
run: yarn lhci autorun
env:
LHCI_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Attach results as artifact to GitHub Actions run
if: ${{ always() }}
uses: actions/upload-artifact@v4
with:
name: lighthouse-results
path: .lighthouseci

0 comments on commit 0fae44b

Please sign in to comment.