Skip to content

Commit

Permalink
Merge pull request #2043 from cfpb/ans_build
Browse files Browse the repository at this point in the history
Combine build scripts
  • Loading branch information
anselmbradford committed Sep 10, 2024
2 parents 4154531 + 412528a commit 21b0f67
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
run: yarn install

- name: Build assets
run: yarn build-packages
run: yarn build

- name: Publish
run: |
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ here's what you'd do:
1. `yarn design-system-link` to [link](https://yarnpkg.com/lang/en/docs/cli/link/) your local CF components.
1. `cd ~/wherever/cfgov-refresh/` to navigate to another project where you'd like to test your buttons changes (in this case, cfgov-refresh).
1. `yarn link @cfpb/cfpb-buttons` to link @cfpb/cfpb-buttons to cfgov-refresh.
1. `yarn build-packages` in cfgov-refresh to compile your stylesheets.
1. `yarn build` in cfgov-refresh to compile your stylesheets.
1. [Start cfgov-refresh](https://cfpb.github.io/cfgov-refresh/usage/) and navigate to a page with buttons to view your @cfpb/cfpb-buttons changes.
1. When you're pleased with your changes, `cd` back to your `design-system` repo and commit your changes: `git commit -am "Fix button border radius"`
1. `git push origin button-fix` to push your branch up to GitHub.
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@
],
"scripts": {
"a11y": "lhci autorun",
"build": "node ./esbuild/docs/build.js",
"build": "node ./esbuild/packages/build.js && node ./esbuild/docs/build.js",
"build-decap": "yarn install && yarn after-install && yarn build && bundle exec jekyll build",
"build-packages": "node ./esbuild/packages/build.js",
"changelog": "./scripts/generate-changelog.sh",
"copy-assets": "./scripts/fonts.sh && cp -r packages/cfpb-design-system/src/components/cfpb-icons/icons docs/_includes/",
"design-system-link": "lerna exec -- yarn link",
Expand Down
3 changes: 0 additions & 3 deletions scripts/pre-release.sh
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
#!/bin/sh
set -e

# Build package assets in the background.
yarn build-packages &

# Make sure everything is current and built and generate changelog.
yarn build

Expand Down

0 comments on commit 21b0f67

Please sign in to comment.