Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update o-expandable_link to o-expandable_cues | RTL fixes #1659

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Update o-expandable_link to o-expandable_cues | RTL fixes #1659

merged 1 commit into from
Jun 22, 2023

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Jun 21, 2023 •
edited
Loading

Changes

  • Update o-expandable_link to more descriptive o-expandable_cues
  • Add fix to RTL code to target the html lang attribute, like elsewhere where we have RTL targeting CSS. Also, correctly align the cue on RTL pages.

Testing

  1. PR preview should show an unchanged expandables page.

https://deploy-preview-1659--cfpb-design-system.netlify.app/design-system/components/expandables

vs

https://cfpb.github.io/design-system/components/expandables

@netlify
Copy link

netlify bot commented Jun 21, 2023

✅ Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 99916ad
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/64931bc371f2780008cec6ad
😎 Deploy Preview https://deploy-preview-1659--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anselmbradford anselmbradford added the lerna-changelog/enhancement lerna label. DO NOT MODIFY label Jun 21, 2023
@BrewCityBoy BrewCityBoy merged commit 76424c5 into main Jun 22, 2023
@BrewCityBoy BrewCityBoy deleted the ans_expandable_updates branch June 22, 2023 20:17
@anselmbradford anselmbradford mentioned this pull request Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrewCityBoy BrewCityBoy BrewCityBoy approved these changes

@wpears wpears Awaiting requested review from wpears

@brandon-rusk brandon-rusk Awaiting requested review from brandon-rusk

Assignees
No one assigned
Labels
lerna-changelog/enhancement lerna label. DO NOT MODIFY
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anselmbradford @BrewCityBoy