Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a-link__large Jump link with large link modifier #1662

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Remove a-link__large Jump link with large link modifier #1662

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7387dd
Remove `.a-link__large` Jump link with large link modifier
anselmbradford Jun 20, 2023
fa366ff
Merge branch 'main' into ans_remove_jump_link_lg
anselmbradford Jun 23, 2023
6cb67a8
Refresh packages
anselmbradford Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions docs/pages/links.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,11 @@ variation_groups:

- variation_group_name: Links with icons
variation_group_description: >-
* An icon should appear after the text it represents.
* An icon should appear after the text it represents.

* Each icon should be used exclusively and consistently for one action.

* The color and font-size of an icon should be the same as the text it represents, including state changes.
* The color and font-size of an icon should be the same as the text it represents, including state changes.

* Icons should never be underlined.
variations:
Expand Down Expand Up @@ -177,19 +177,6 @@ variation_groups:
<span class="a-link_text">Default jump link</span>
{% include icons/right.svg %}
</a>
- variation_name: Large jump link
variation_description:
The large jump link has an 18px `font-size`, compared to
the default of 16px.
variation_code_snippet: |-
<a class="a-link
a-link__jump
a-link__icon-after-text
a-link__large"
href="#">
<span class="a-link_text">Large jump link</span>
{% include icons/right.svg %}
</a>
- variation_name: Jump link with icon on left
variation_description: Jump links can also have icons before the text, like icon links.
variation_code_snippet: |-
Expand Down
2 changes: 1 addition & 1 deletion packages/cfpb-typography/cfpb-typography.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions packages/cfpb-typography/src/atoms/links.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@
.a-link__jump {
font-weight: 500;

&.a-link__large {
font-size: unit((@size-iv / @base-font-size-px), em);
}

.respond-to-max( @bp-xs-max, {
.u-block-link();

Expand Down
24 changes: 0 additions & 24 deletions packages/cfpb-typography/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,30 +309,6 @@ to full block links that have a finger-friendly touch area.
</a>
```

#### Jump link with large link modifier

The large jump link has an `18px` `font-size`, compared to the default of `16px`.

<a class="a-link
a-link__jump
a-link__icon-after-text
a-link__large"
href="#">
<span class="a-link_text">Large jump link</span>
{% include icons/right.svg %}
</a>

```
<a class="a-link
a-link__jump
a-link__icon-after-text
a-link__large"
href="#">
<span class="a-link_text">Large jump link</span>
{% raw %}{% include icons/right.svg %}{% endraw %}
</a>
```

#### Jump link with icon on the left

Jump links can also have icons before the text, like icon links.
Expand Down