cfpb-layout: Fix breakout card margin #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
BrewCityBoy
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1663 fixed a typo in the less syntax, however, this needs to also exclude the breakout cards so that they don't have their top margin overridden with
auto.Also, I noticed that calculations need to be wrapped in parentheses to be applied, otherwise the value ends up as
120px / 2or whatever, instead of60px.Changes
Testing
PR preview: https://deploy-preview-1668--cfpb-design-system.netlify.app/design-system/patterns/cards
Live site: https://cfpb.github.io/design-system/patterns/cards
Screenshots
Before:
After:
