second level nav missing #1673
Merged
second level nav missing #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hmm if I go to https://deploy-preview-1673--cfpb-design-system.netlify.app/design-system/pages/ now there are NO links! |
Perhaps the script in sidebar.html is looking for the h5 'eyebrow' tag, but none of the pages md files have that tag? I think it's the file structure. |
|
Scratch the idea about the file structure in the 'md' files. The "pages" needed to be indented into the second level in the side-navigation.yml file. |
anselmbradford
approved these changes
Jul 18, 2023
|
Fixes #1294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for missing indentation of "Pages" links in Design System sidenav. Taken from Issue 1294:
It's weird that https://cfpb.github.io/design-system/pages/ doesn't have indented links, unlike every other section: