-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cfpb-icons: Add numerical icons #1677
Conversation
I think the historical reason for this is that we put CSS in place to replicate them. There may have also been a licensing concern about the numerals being sourced from Avenir Next. |
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
74e9e88
to
4463faf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢
Thanks @Scotchester ! I'm holding the PR till we verify the licensing. |
I recommend moving forward with the PR if this is time-sensitive or blocking other work. I'm still waiting to hear back from the licensing rep, but I don't anticipate there being an issue. |
We had numerical icons in the source svg folder, but hadn't included them in the DS docs for some reason.
Additions
Testing
Screenshots