Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfpb-icons: Add numerical icons #1677

Merged
merged 1 commit into from
Jul 21, 2023
Merged

cfpb-icons: Add numerical icons #1677

merged 1 commit into from
Jul 21, 2023

Conversation

anselmbradford
Copy link
Member

We had numerical icons in the source svg folder, but hadn't included them in the DS docs for some reason.

Additions

  • Add numerical icons to the docs.

Testing

  1. The PR preview iconography page should include icons.

Screenshots

Screenshot 2023-07-20 at 3 13 15 PM

@anselmbradford anselmbradford changed the title Add numerical icons cfpb-icons: Add numerical icons Jul 20, 2023
@anselmbradford anselmbradford added the lerna-changelog/enhancement lerna label. DO NOT MODIFY label Jul 20, 2023
@Scotchester
Copy link
Contributor

I think the historical reason for this is that we put CSS in place to replicate them. There may have also been a licensing concern about the numerals being sourced from Avenir Next.

@netlify
Copy link

netlify bot commented Jul 20, 2023

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 4463faf
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/64b9891f864fb90008476ee5
😎 Deploy Preview https://deploy-preview-1677--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢

@anselmbradford
Copy link
Member Author

I think the historical reason for this is that we put CSS in place to replicate them. There may have also been a licensing concern about the numerals being sourced from Avenir Next.

Thanks @Scotchester ! I'm holding the PR till we verify the licensing.

@doguin
Copy link
Member

doguin commented Jul 21, 2023

I think the historical reason for this is that we put CSS in place to replicate them. There may have also been a licensing concern about the numerals being sourced from Avenir Next.

Thanks @Scotchester ! I'm holding the PR till we verify the licensing.

I recommend moving forward with the PR if this is time-sensitive or blocking other work. I'm still waiting to hear back from the licensing rep, but I don't anticipate there being an issue.

@anselmbradford anselmbradford merged commit ad3783a into main Jul 21, 2023
@anselmbradford anselmbradford deleted the ans_add_missing_icons branch July 21, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/enhancement lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants