Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to yarn 4.5.1 #1916

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Update to yarn 4.5.1 #1916

merged 2 commits into from
Oct 24, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Feb 22, 2024

This is aligning yarn with the setup in https://github.com/cfpb/design-system-react, but I added additional config in cfpb/design-system-react#337

Please scrutinize the config that I did this right. Config options are here https://yarnpkg.com/configuration/yarnrc.

Changes

  • Update to [email protected]
  • Removes npm-packages-offline-cache and replaces it with .yarn/cache

Testing

  1. Check that yarn config makes sense.
  2. yarn install should pass.
  3. PR checks should pass.

@anselmbradford anselmbradford added the lerna-changelog/internal lerna label. DO NOT MODIFY label Feb 22, 2024
Copy link

netlify bot commented Feb 22, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit a799119
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/671a9fe2d8bcca00083a6e87
😎 Deploy Preview https://deploy-preview-1916--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anselmbradford anselmbradford force-pushed the ans_upgrade_yarn branch 4 times, most recently from 343f4c8 to ebfdf73 Compare April 19, 2024 21:52
@anselmbradford anselmbradford changed the title Update to yarn 4.1.0 Update to yarn 4.1.1 Apr 19, 2024
@anselmbradford anselmbradford force-pushed the ans_upgrade_yarn branch 5 times, most recently from f243b64 to 01a73d7 Compare May 7, 2024 22:23
@anselmbradford anselmbradford changed the title Update to yarn 4.1.1 Update to yarn 4.2.1 May 7, 2024
@anselmbradford anselmbradford changed the title Update to yarn 4.2.1 Update to yarn 4.3.0 Jun 14, 2024
@anselmbradford anselmbradford changed the title Update to yarn 4.3.0 Update to yarn 4.4.0 Aug 22, 2024
@anselmbradford anselmbradford changed the title Update to yarn 4.4.0 Update to yarn 4.5.0 Oct 16, 2024
@anselmbradford anselmbradford force-pushed the ans_upgrade_yarn branch 2 times, most recently from 96bf5f2 to 73096f7 Compare October 16, 2024 15:12
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggested changes. I fee like if we're going to use Yarn v4 we should use their recommended default settings to get as much performance as possible.

.yarnrc.yml Outdated Show resolved Hide resolved
.yarnrc.yml Show resolved Hide resolved
@anselmbradford anselmbradford changed the title Update to yarn 4.5.0 Update to yarn 4.5.1 Oct 24, 2024
@anselmbradford anselmbradford merged commit eb1d299 into main Oct 24, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_upgrade_yarn branch October 24, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/internal lerna label. DO NOT MODIFY
Projects
Development

Successfully merging this pull request may close these issues.

2 participants