Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCM: Unquote padding-bottom value in video-playing class #2024

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

anselmbradford
Copy link
Member

This value was invalid if it was quoted, so this unquotes it.

Changes

  • FCM: Unquote padding-bottom value in video-playing class

Testing

  1. This shows up on FCM videos, such as on https://www.consumerfinance.gov/consumer-tools/reverse-mortgages/, where if the value was quoted the video play area would be squashed to zero pixels.

@anselmbradford anselmbradford added the lerna-changelog/bug lerna label. DO NOT MODIFY label Aug 21, 2024
Copy link

netlify bot commented Aug 21, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 0972a29
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/66c641458fbd1e000719f7a7
😎 Deploy Preview https://deploy-preview-2024--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anselmbradford anselmbradford merged commit 7e0479c into main Aug 21, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_unquote branch August 21, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/bug lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant