Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags: Add initial tag styling #2026

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Tags: Add initial tag styling #2026

merged 2 commits into from
Aug 22, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Aug 22, 2024

Additions

  • Tags: Add initial tag styling

Testing

  1. Check the tags page at https://deploy-preview-2026--cfpb-design-system.netlify.app/design-system/components/tags

Copy link

netlify bot commented Aug 22, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit cad141f
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/66c7506c202d660008209b8e
😎 Deploy Preview https://deploy-preview-2026--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jenn-franklin jenn-franklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small edit: In looking at filter tags on the blog and Selects page, it looks like the text should be regular vs. medium weight.

@anselmbradford
Copy link
Member Author

One small edit: In looking at filter tags on the blog and Selects page, it looks like the text should be regular vs. medium weight.

@jenn-franklin
So in TDP and prepaid it is medium (also CCDB, but that's its own beast)

https://www.consumerfinance.gov/consumer-tools/educator-tools/youth-financial-education/teach/activities/?grade_level=3
https://www.consumerfinance.gov/data-research/prepaid-accounts/search-agreements/?prepaid_type=GPR+%28General+Purpose+Reloadable%29

Do we want all cases to be regular or medium? Or do we want two versions (which I'd discourage).

@jenn-franklin
Copy link
Member

Omg 😩

I agree with you regarding discouraging two versions. I think we should go with regular weight since this is currently our standard in places like the blog, DS Selects page, and Figma file.

I did contemplate if medium might look better and the fact that medium would be more in line with the button's styling. But we want to ensure tags aren't confused with buttons, so I think regular weight is actually better in that regard. And since regular weight is accessible on this teal background, we're good from a contrast perspective.

@anselmbradford anselmbradford merged commit 6c65bd3 into main Aug 22, 2024
7 of 8 checks passed
@anselmbradford anselmbradford deleted the ans_tags branch August 22, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants