Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust focus rectangle offset for default links, expandables, summaries #2037

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Sep 5, 2024

Fixes #2032

Makes some focus rectangle offset adjustments to make our spacing more consistent.

Changes

  • Adjust focus rectangle offset for default links, expandables, summaries, so that there is a 1px gap between any borders.

Testing

  1. Check out the links, expandables, and summary pages in the PR preview https://deploy-preview-2037--cfpb-design-system.netlify.app/ and see that when tabbing to the examples that the focus rectangle is offset 1px from any borders.

Screenshots

Before:

Screenshot 2024-09-05 at 5 01 23 PM

After:
Screenshot 2024-09-05 at 5 02 07 PM

Before:
Screenshot 2024-09-05 at 5 01 37 PM

After:
Screenshot 2024-09-05 at 5 01 17 PM

@anselmbradford anselmbradford added the lerna-changelog/bug lerna label. DO NOT MODIFY label Sep 5, 2024
Copy link

netlify bot commented Sep 5, 2024

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 3ed54e6
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/66da31902256a50008d6e7f6
😎 Deploy Preview https://deploy-preview-2037--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@wpears wpears left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@anselmbradford anselmbradford merged commit ae4a124 into main Sep 6, 2024
8 checks passed
@anselmbradford anselmbradford deleted the ans_default_offset branch September 6, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lerna-changelog/bug lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link focus example not correct
2 participants