Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor V619_2 edits to use dynamic dates #4904

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Refactor V619_2 edits to use dynamic dates #4904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c7b159
Add new V619_2 edit with dynamic year.
jaredb96 Sep 20, 2024
d8cc500
Remove 2023 package to fix bug and add unit test for 2023.
jaredb96 Sep 23, 2024
afcead6
Resolve merge conflict.
jaredb96 Sep 24, 2024
3d14619
Consolidate tests to avoid duplication.
jaredb96 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2018/LarEngine2018.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package hmda.validation.engine
import hmda.model.filing.lar.LoanApplicationRegister
import hmda.validation.context.ValidationContext
import hmda.validation.rules.lar.quality._2018._
import hmda.validation.rules.lar.validity.common.V619_2
import hmda.validation.rules.lar.quality.common._
import hmda.validation.rules.lar.syntactical.{ S300, S301 }
import hmda.validation.rules.lar.validity.{_2018,_}
Expand Down Expand Up @@ -40,7 +41,7 @@ private[engine] object LarEngine2018 extends ValidationEngine[LoanApplicationReg
V617,
V618,
V619_1,
_2018.V619_2,
V619_2.withYear("2018"),
V619_3,
V620,
V621,
Expand Down
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2019/LarEngine2019.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package hmda.validation.engine
import hmda.model.filing.lar.LoanApplicationRegister
import hmda.validation.context.ValidationContext
import hmda.validation.rules.lar.quality._2019._
import hmda.validation.rules.lar.validity.common.V619_2
import hmda.validation.rules.lar.quality.common._
import hmda.validation.rules.lar.syntactical.{ S300, S301 }
import hmda.validation.rules.lar.validity.{_2019,_}
Expand Down Expand Up @@ -41,7 +42,7 @@ private[engine] object LarEngine2019 extends ValidationEngine[LoanApplicationReg
V617,
V618,
V619_1,
_2019.V619_2,
V619_2.withYear("2019"),
V619_3,
V620,
V621,
Expand Down
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2020/LarEngine2020.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package hmda.validation.engine
import hmda.model.filing.lar.LoanApplicationRegister
import hmda.validation.context.ValidationContext
import hmda.validation.rules.lar.quality._2019._
import hmda.validation.rules.lar.validity.common.V619_2
import hmda.validation.rules.lar.quality.{common, _2020 => quality2020}
import hmda.validation.rules.lar.quality.common._
import hmda.validation.rules.lar.syntactical.{S300, S301}
Expand Down Expand Up @@ -43,7 +44,7 @@ private[engine] object LarEngine2020 extends ValidationEngine[LoanApplicationReg
V617,
V618,
V619_1,
_2020.V619_2,
V619_2.withYear("2020"),
V619_3,
V620,
V621,
Expand Down
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2020Qscala/LarEngine2020Q.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import hmda.validation.rules.lar.validity._
import hmda.validation.rules.lar.validity._2020
import hmda.census.records.CensusRecords
import hmda.validation.rules.lar.validity._2020.V716
import hmda.validation.rules.lar.validity.common.V619_2

private[engine] object LarEngine2020Q extends ValidationEngine[LoanApplicationRegister] {

Expand Down Expand Up @@ -43,7 +44,7 @@ private[engine] object LarEngine2020Q extends ValidationEngine[LoanApplicationRe
V617,
V618,
V619_1,
_2020.V619_2,
V619_2.withYear("2020"),
V619_3,
V620,
V621,
Expand Down
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2021/LarEngine2021.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package hmda.validation.engine
import hmda.model.filing.lar.LoanApplicationRegister
import hmda.validation.context.ValidationContext
import hmda.validation.rules.lar.quality.{_2020 => quality2020, _2021 => quality2021}
import hmda.validation.rules.lar.validity.common.V619_2
import hmda.validation.rules.lar.quality.common._
import hmda.validation.rules.lar.syntactical.{S300, S301}
import hmda.validation.rules.lar.validity._
Expand Down Expand Up @@ -41,7 +42,7 @@ private[engine] object LarEngine2021 extends ValidationEngine[LoanApplicationReg
V617,
V618,
V619_1,
_2021.V619_2,
V619_2.withYear("2021"),
V619_3,
V620,
V621,
Expand Down
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2021Qscala/LarEngine2021Q.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import hmda.validation.rules.lar.syntactical.{S300, S301}
import hmda.validation.rules.lar.validity._
import hmda.validation.rules.lar.validity._2020
import hmda.census.records.CensusRecords
import hmda.validation.rules.lar.validity.common.V619_2

private[engine] object LarEngine2021Q extends ValidationEngine[LoanApplicationRegister] {

Expand Down Expand Up @@ -42,7 +43,7 @@ private[engine] object LarEngine2021Q extends ValidationEngine[LoanApplicationRe
V617,
V618,
V619_1,
_2021.V619_2,
V619_2.withYear("2021"),
V619_3,
V620,
V621,
Expand Down
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2022/LarEngine2022.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package hmda.validation.engine
import hmda.model.filing.lar.LoanApplicationRegister
import hmda.validation.context.ValidationContext
import hmda.validation.rules.lar.quality._2019._
import hmda.validation.rules.lar.validity.common.V619_2
import hmda.validation.rules.lar.quality.{_2020 => quality2020, _2021 => quality2021, _2022 => quality2022}
import hmda.validation.rules.lar.quality.common._
import hmda.validation.rules.lar.syntactical.{S300, S301}
Expand Down Expand Up @@ -42,7 +43,7 @@ private[engine] object LarEngine2022 extends ValidationEngine[LoanApplicationReg
V617,
V618,
V619_1,
_2022.V619_2,
V619_2.withYear("2022"),
V619_3,
V620,
V621,
Expand Down
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2022Qscala/LarEngine2022Q.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import hmda.validation.rules.lar.quality.common._
import hmda.validation.rules.lar.syntactical.{S300, S301}
import hmda.validation.rules.lar.validity.{_2020, _2022, _}
import hmda.census.records.CensusRecords
import hmda.validation.rules.lar.validity.common.V619_2

private[engine] object LarEngine2022Q extends ValidationEngine[LoanApplicationRegister] {

Expand Down Expand Up @@ -42,7 +43,7 @@ private[engine] object LarEngine2022Q extends ValidationEngine[LoanApplicationRe
V617,
V618,
V619_1,
_2022.V619_2,
V619_2.withYear("2022"),
V619_3,
V620,
V621,
Expand Down
5 changes: 3 additions & 2 deletions hmda/src/main/scala/hmda/validation/engine/2023/LarEngine2023.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ package hmda.validation.engine
import hmda.model.filing.lar.LoanApplicationRegister
import hmda.validation.context.ValidationContext
import hmda.validation.rules.lar.quality._2019._
import hmda.validation.rules.lar.validity.common.V619_2
import hmda.validation.rules.lar.quality.{_2020 => quality2020, _2021 => quality2021, _2022 => quality2022}
import hmda.validation.rules.lar.quality.common._
import hmda.validation.rules.lar.syntactical.{S300, S301}
import hmda.validation.rules.lar.validity.{_2020, _2022, _2023, _}
import hmda.validation.rules.lar.validity.{_2020, _2022, _}
import hmda.census.records.CensusRecords

private[engine] object LarEngine2023 extends ValidationEngine[LoanApplicationRegister] {
Expand Down Expand Up @@ -42,7 +43,7 @@ private[engine] object LarEngine2023 extends ValidationEngine[LoanApplicationReg
V617,
V618,
V619_1,
_2023.V619_2,
V619_2.withYear("2023"),
V619_3,
V620,
V621,
Expand Down
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2023Qscala/LarEngine2023Q.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import hmda.validation.rules.lar.quality.common._
import hmda.validation.rules.lar.syntactical.{S300, S301}
import hmda.validation.rules.lar.validity.{_2020, _2022, _}
import hmda.census.records.CensusRecords
import hmda.validation.rules.lar.validity.common.V619_2

private[engine] object LarEngine2023Q extends ValidationEngine[LoanApplicationRegister] {

Expand Down Expand Up @@ -42,7 +43,7 @@ private[engine] object LarEngine2023Q extends ValidationEngine[LoanApplicationRe
V617,
V618,
V619_1,
_2023.V619_2,
V619_2.withYear("2023"),
V619_3,
V620,
V621,
Expand Down
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2024/LarEngine2024.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package hmda.validation.engine
import hmda.model.filing.lar.LoanApplicationRegister
import hmda.validation.context.ValidationContext
import hmda.validation.rules.lar.quality._2019._
import hmda.validation.rules.lar.validity.common.V619_2
import hmda.validation.rules.lar.quality.{_2020 => quality2020, _2021 => quality2021, _2022 => quality2022, _2025 => quality2025}
import hmda.validation.rules.lar.quality.common._
import hmda.validation.rules.lar.syntactical.{S300, S301}
Expand Down Expand Up @@ -43,7 +44,7 @@ private[engine] object LarEngine2024 extends ValidationEngine[LoanApplicationReg
V617,
V618,
V619_1,
_2024.V619_2,
V619_2.withYear("2024"),
V619_3,
V620,
V621,
Expand Down
3 changes: 2 additions & 1 deletion hmda/src/main/scala/hmda/validation/engine/2025/LarEngine2025.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ package hmda.validation.engine
import hmda.model.filing.lar.LoanApplicationRegister
import hmda.validation.context.ValidationContext
import hmda.validation.rules.lar.quality._2019._
import hmda.validation.rules.lar.validity.common.V619_2
import hmda.validation.rules.lar.quality.{_2020 => quality2020, _2021 => quality2021, _2022 => quality2022, _2025 => quality2025}
import hmda.validation.rules.lar.quality.common._
import hmda.validation.rules.lar.syntactical.{S300, S301}
Expand Down Expand Up @@ -43,7 +44,7 @@ private[engine] object LarEngine2025 extends ValidationEngine[LoanApplicationReg
V617,
V618,
V619_1,
_2025.V619_2,
V619_2.withYear("2025"),
V619_3,
V620,
V621,
Expand Down
20 changes: 0 additions & 20 deletions hmda/src/main/scala/hmda/validation/rules/lar/validity/2018/V619_2.scala
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions hmda/src/main/scala/hmda/validation/rules/lar/validity/2019/V619_2.scala
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions hmda/src/main/scala/hmda/validation/rules/lar/validity/2020/V619_2.scala
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions hmda/src/main/scala/hmda/validation/rules/lar/validity/2021/V619_2.scala
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions hmda/src/main/scala/hmda/validation/rules/lar/validity/2022/V619_2.scala
View file
Open in desktop

This file was deleted.

21 changes: 0 additions & 21 deletions hmda/src/main/scala/hmda/validation/rules/lar/validity/2024/V619_2.scala
View file
Open in desktop

This file was deleted.

15 changes: 9 additions & 6 deletions ...tion/rules/lar/validity/2023/V619_2.scala → ...on/rules/lar/validity/common/V619_2.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
package hmda.validation.rules.lar.validity._2023

package hmda.validation.rules.lar.validity.common

import hmda.model.filing.lar.LoanApplicationRegister
import hmda.validation.dsl.PredicateCommon._
import hmda.validation.dsl.PredicateSyntax._
import hmda.validation.dsl.ValidationResult
import hmda.validation.rules.EditCheck

object V619_2 extends EditCheck[LoanApplicationRegister] {
object V619_2 {
def withYear(year: String): EditCheck[LoanApplicationRegister] =
new V619_2(year)

}

class V619_2 private (year: String) extends EditCheck[LoanApplicationRegister] {
override def name: String = "V619-2"

override def parent: String = "V619"

override def apply(lar: LoanApplicationRegister): ValidationResult = {
val year = "2023"

lar.action.actionTakenDate.toString.slice(0, 4) is equalTo(year)
}

}
}
28 changes: 0 additions & 28 deletions hmda/src/test/scala/hmda/validation/rules/lar/validity/2019/V619_2Spec.scala
View file
Open in desktop

This file was deleted.

Loading
Loading