Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Investigate performance issues #1025

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

tanner-ricks
Copy link
Contributor

Adjusted timeouts to make e2e tests run consistently with up to 4 workers.

Changes

  • Added explicit timeouts to the playwright configuration
    • Test Suite Timeout of 1 Hour
    • Individual Test Timeout of 5 Minutes
    • Expect Timeout of 60 Seconds
  • Removed individual expect timeouts from tests
  • Removed test.slow calls
  • Removed test.setTimeout calls
  • Created functions for clicking the 'continue' and 'continue to next step' buttons
    • Allowed the continue to next function to explicitly wait before clicking the button
    • This was a large part of the fix and as such these functions should be used in the future
  • Replaced all instances of clicking 'Continue' and 'Continue to next step' buttons with the new functions

How to test this PR

  1. Pull the branch
  2. Restart the stack if necessary
  3. From within the sbl-frontend directory run the following command: yarn playwright test --ui --workers 4
  4. In the Playwright UI that appears run all of the tests together
  5. Verify that all tests pass
  6. Run them all again
  7. Verify that they all still pass

Screen shots

Screenshot 2024-10-23 at 2 43 44 PM

Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏾

I'm still seeing consistent failures on a few tests but this is probably an issue with my local setup.

Screenshot 2024-10-24 at 5 09 35 PM Screenshot 2024-10-28 at 9 34 41 AM Screenshot 2024-10-24 at 5 09 03 PM Screenshot 2024-10-24 at 5 09 19 PM

@tanner-ricks tanner-ricks merged commit c7167c4 into main Oct 28, 2024
4 checks passed
@tanner-ricks tanner-ricks deleted the 1017-e2e-worker-performance branch October 28, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[e2e] Investigate performance issues
2 participants