Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): improve documentation on how to build ch32v003 examples #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dickenhobelix
Copy link

add a short comment on how to configure rust nightly for building the ch32v003 examples

the previous version selected by cargo with "*" (0.2.0) caused the build to
break with an error failed to load bitcode of module
"qingke-c4359a58ea77d2f5.qingke.ea2e92fc367b3625-cgu.0.rcgu.o"
@@ -21,7 +21,7 @@ embassy-time = { version = "0.3.0" }

# This is okay because we should automatically use whatever ch32-hal uses
qingke = "*"
qingke-rt = { version = "*", features = ["highcode"] }
qingke-rt = { version = "0.5.0", features=["highcode"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please format your code
  2. Have you tried cleaning / clean build and this is still necessary? My understanding is that * will match whatever qingke that ch32-hal uses. Which should be 0.5 in the main branch Unless you have some lock file lingering around. Please correct me if I'm mistaken about this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

1.: Sure. Is there any formatter for Cargo toml that you recommend?

2.: I just did a clean clone of the master branch so I would suspect there is nothing else around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants