-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: install playwright deps before playwright #86
Conversation
nevermind this actually just uncovered another error - that some of these dependencies don't exist in whatever distro we're using... |
I think deps need to be updated also. |
We currently install playwright before its dependencies, and this seems to be causing our CI to fail since a new playwright release at some point. Switching them around should fix it.
2a8b9e7
to
964d028
Compare
lets sort all the renovate PRs first and see if this runs once i update the branch |
@43081j doesn't look like updating all the deps fixed this issue either 😢 |
renovate only looks at our direct dependencies i think so i did an but now we have that same old rollup lockfile problem.
|
reinstalling web test runner seems to have fixed it big lockfile diff but looks ok |
Nice work! |
@43081j @keithamus Side note: I think you can merge the two commands into one using the |
i think this will sort what you're trying to do @keithamus