fix(cg-actions): HTML by-workflow action names + readable mixed note#7
Closed
tylerpaxton wants to merge 1 commit into
Closed
fix(cg-actions): HTML by-workflow action names + readable mixed note#7tylerpaxton wants to merge 1 commit into
tylerpaxton wants to merge 1 commit into
Conversation
A) The by-workflow detail cards keyed rows on a.get("action", ""), but the
inventory stores the name under "name". Result: every "Current" cell rendered
"@v6" with no action name, and all actions in a workflow collapsed under one
empty key. Use a.get("action") or a.get("name", "") (matches the main table).
B) The mixed-version note printed the raw status ("v6 → True"); map it to a label
so it reads "v6 → available; v4 → version gap".
Verified against tylerpaxton/cg-actions-test: by-workflow rows now show
"actions/setup-node@v4 → … version-gap" with the name present, and the mixed note
is human-readable.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #9, which consolidates this into a single reviewable PR (one commit per change, single VERSION bump). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two display bugs in the HTML report, both in the multi-version view.
A — by-workflow rows dropped the action name. The detail cards keyed rows on
a.get("action", ""), but the inventory stores the name under"name". So every "Current" cell rendered@v6(no action name), and all actions in a workflow collapsed under one empty key. Fixed toa.get("action") or a.get("name", "")— matching what the main inventory table already does. (Per-version status/target were correct; only the labeling was broken.)B — mixed note showed a raw value. The
mixedrow's note printedv6 → Trueinstead ofv6 → available. Now maps the status to a label.Verified against
tylerpaxton/cg-actions-testactions/setup-node@v6 → … available,actions/setup-node@v4 → … version-gap(name present).varies by version: v6 → available; v4 → version gap.🤖 Generated with Claude Code