Round managment + Update bitvm dependency #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new database tables for tracking round index and used kickoff connectors - Implemented `handle_finalized_payout` method in Operator to manage deposit payouts - Updated transaction signing to return full Transaction instead of RawSignedTx - Added methods to get and update current round index - Modified RPC serialization to use bitcoin consensus serialization
…acan/handle_kickoff
Atacan/handle_kickoff
…acan/handle_kickoff
mmtftr
reviewed
Mar 3, 2025
core/src/config/protocol.rs
Outdated
| disprove_timeout_timelock: 250, | ||
| assert_timeout_timelock: 200, | ||
| operator_reimburse_timelock: 48, | ||
| watchtower_challenge_timeout_timelock: 200, |
atacann
reviewed
Mar 3, 2025
core/src/utils.rs
Outdated
| vec![ | ||
| (self.latest_blockhash_pk.to_vec(), 20), | ||
| (self.challenge_sending_watchtowers_pk.to_vec(), 20), | ||
| (self.bitvm_pks.0[0].to_vec(), 32), |
There was a problem hiding this comment.
needs to be * 2 for all WinternitzCommits in this function, because it needs message (digit) length not byte length
ceyhunsen
requested changes
Mar 3, 2025
atacann
reviewed
Mar 3, 2025
core/src/builder/script.rs
Outdated
| // let kp = bitcoin::secp256k1::Keypair::new(&SECP, &mut rand::thread_rng()); | ||
| // let xonly_pk = kp.public_key().x_only_public_key().0; | ||
|
|
||
| // let derivation = WinternitzDerivationPath::BitvmAssert( |
There was a problem hiding this comment.
Uncomment test, something like below works.
One other idea is that we can only store pk_type and idx here, have a function that returns byte_size of a pk_type inside the new bitvm struct, then we can get message lengths from pk_type so that we do not pass message length everywhere and its easy to change
Suggested change
| // let derivation = WinternitzDerivationPath::BitvmAssert( | |
| let derivation = WinternitzDerivationPath::BitvmAssert( | |
| 64, | |
| 3, | |
| 0, | |
| Txid::all_zeros(), | |
| ProtocolParamsetName::Regtest.into(), | |
| ); |
There was a problem hiding this comment.
re-added the test in 6781fae
i think it is okay to send the message length for now?
ceyhunsen
approved these changes
Mar 3, 2025
ekrembal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 2 internal grpc endpoints for operator: finalized payout tx and end round
Add tx names and details in tx_sender for better logging
Handled tx_sender errors, when it panics it stops the whole process
Updated BitVM dependency to not use patches
Linked Issues
Testing
Tested that the operator can get a reimbursment after calling end-round