fix(solid): make tooltip trigger work as expected#573
Open
pedrodesu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an
asChildequivalent for the Trigger component in the Solid.js implementation to align its API with the React version.The Issue
As of now, the Solid.js Trigger is hardcoded to wrap its children in a structural container (
<Trigger>{children}</Trigger>). Unlike the React implementation, which utilizes anasChildprop to allow consumers to bypass this wrapper and merge trigger functionality onto their own components, the Solid.js version lacks this flexibility. This limits consumer control over the underlying DOM structure and makes it difficult to integrate custom button components. You either end up with nested button elements with different functionalities, or lose functionality.The Solution
This change introduces an
asChildsupport pattern within the Solid.js Trigger wrapper. It now detects if a function (render prop) is passed as a child.asChildbehavior).This ensures full parity with the React implementation and improves component composability.
Before:
After: