Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Fix wrong order in enrollments list #956

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

evamillan
Copy link
Contributor

This PR changes the list of enrollments to use the order provided by the API (sorted by date by default) instead of grouping them by organization.

Fixes #955.

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good but there are some style checks the code is not passing. Can you check them?

Uses the order provided by the API -sorted by date
by default- for the list of enrollments instead of
grouping them by organization.

Signed-off-by: Eva Millán <[email protected]>
@evamillan evamillan force-pushed the affiliation-order-bug branch from 22ced58 to c4447a1 Compare March 4, 2025 16:00
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit 752dd31 into chaoss:main Mar 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple affiliations to same company cause wrong affiliations order
2 participants