Skip to content

test: let phan see Translate instead of looking away from it #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lens0021 merged 2 commits into from
Aug 18, 2026
+3 −24
Merged

test: let phan see Translate instead of looking away from it #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b43fa55
test: let phan see Translate instead of looking away from it
lens0021 Aug 17, 2026
82d3cde
Update config.php
lens0021 Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .phan/config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@

$cfg = require __DIR__ . '/../vendor/mediawiki/mediawiki-phan-config/src/config.php';

// Gadgets is optional (referenced behind class_exists guards); phan resolves it without analysing.
// Optional extensions
$cfg['directory_list'][] = '../../extensions/Gadgets';
$cfg['exclude_analysis_directory_list'][] = '../../extensions/Gadgets';
$cfg['directory_list'][] = '../../extensions/Translate';
$cfg['exclude_analysis_directory_list'][] = '../../extensions/Translate';

return $cfg;
6 changes: 0 additions & 6 deletions includes/Hooks/Indexer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
<?php
/**
* Translate is an optional, image-bundled dependency that phan does not analyse, so its symbols
* are undeclared to static analysis here. It is only asked anything once it has said it is loaded.
*
* @phan-file-suppress PhanUndeclaredClassMethod
*/

namespace MediaWiki\Extension\Wikven\Hooks;

Expand Down
9 changes: 0 additions & 9 deletions maintenance/buildTranslations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
<?php
/**
* Translate is an optional, image-bundled dependency that phan does not analyse, so its symbols
* are undeclared to static analysis here. This script only runs when Translate is loaded.
*
* @phan-file-suppress PhanUndeclaredClassMethod
* @phan-file-suppress PhanUndeclaredClassConstant
* @phan-file-suppress PhanUndeclaredConstant
* @phan-file-suppress PhanUndeclaredClassCatch
*/

namespace MediaWiki\Extension\Wikven;

Expand Down
8 changes: 0 additions & 8 deletions maintenance/checkTranslations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@
<?php
/**
* Translate is an optional, image-bundled dependency that phan does not analyse, so its symbols
* are undeclared to static analysis here. Reading a page with Translate's own parser only happens
* when Translate is loaded.
*
* @phan-file-suppress PhanUndeclaredClassMethod
* @phan-file-suppress PhanUndeclaredClassCatch
*/

namespace MediaWiki\Extension\Wikven;

Expand Down
Loading