Flatten Yaml Scalar Test

[russellbanks]

#27 (comment)

listOf has been replaced with withData

[russellbanks]

Float.NaN == Float.NaN is false in Kotlin/JS so equality for NaN should be done by isNaN(). In Kotest, this corresponds to shouldBeNaN() so I've put tests relating to NaN separately so they work in JavaScript.

[russellbanks]

@charleskorn One issue is that the tests 0x2 and 0o2 are successfully converted to a float in JavaScript (On the JVM it throws an exception).

val scalar = YamlScalar("0x2", index1Line2Column4Path)

val floatException = shouldThrow<YamlScalarFormatException>(scalar::toFloat) // Gets converted to 2 in JS

On the JVM, the test passes. On JavaScript, there is AssertionError: Expected exception YamlScalarFormatException but no exception was thrown.

The below functions might need extra logic to cover this edge case in JavaScript:

kaml/src/commonMain/kotlin/com/charleskorn/kaml/YamlNode.kt

Line 56 in 7461bb1

public fun toFloat(): Float {

kaml/src/commonMain/kotlin/com/charleskorn/kaml/YamlNode.kt

Line 70 in 7461bb1

public fun toDouble(): Double {

[charleskorn]

One issue is that the tests 0x2 and 0o2 are successfully converted to a float in JavaScript (On the JVM it throws an exception).

...

The below functions might need extra logic to cover this edge case in JavaScript:

This makes sense to me - could you please add this extra logic with expect / actual declarations for each target?

Alternatively, should we raise this as a Kotlin bug? I'd expect those methods to behave identically across platforms.

[russellbanks]

Alternatively, should we raise this as a Kotlin bug? I'd expect those methods to behave identically across platforms.

I'm not sure with this honestly. Looking at the code in Kotlin, they just delegate the behaviour to their related platforms.

[stale]

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. It will automatically be closed if no further activity occurs in the next seven days to enable maintainers to focus on the most important issues.
If this issue is still affecting you, please comment below within the next seven days.
Thank you for your contributions.

[stale]

This issue has been automatically closed because it has not had any recent activity.