Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support alternate names for ceph-fs charm and associated storage class #33

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

addyess
Copy link
Member

@addyess addyess commented Jan 29, 2025

Overview

When the ceph cluster charm ceph-fs is deployed with an alternate application name, (eg ceph-fs-alt) the output after querying the cluster was an unexpected response.

ceph fs ls
[{
  "name":"ceph-fs-alt",
  "metadata_pool":"ceph-fs-alt_metadata",
  "metadata_pool_id":5,
  "data_pool_ids":[4],
  "data_pools":["ceph-fs-alt_data"]
}]

This led to needing to redesign for situations where there may be multiple ceph-fs pools, and the ability to create multiple storage classes based on the pool structure -- while maintaining that if theres is only one pool, it's name still resolves to cephfs

Details

  • a new config cephfs-storage-class-name-formatter allows the charm admin to format the CephFS storage class name based on some context variables.
  • the context provided to the CephFS Manifest is significantly revamps to support this more complete filesystem pool listing
  • Increase the error checking for situations where the formatter isn't detailed enough to provide unique storage-class names

@addyess addyess force-pushed the KU-2531/flexible-ceph-fs-charm-name branch from a425f8b to 1afd914 Compare January 31, 2025 19:54
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyess addyess merged commit 161dfbc into main Feb 3, 2025
7 checks passed
@addyess addyess deleted the KU-2531/flexible-ceph-fs-charm-name branch February 3, 2025 14:17
HomayoonAlimohammadi pushed a commit that referenced this pull request Feb 5, 2025
#33)

* Support alternate names for ceph-fs charm and associated storage class

* Pythonic error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants