Create a formatter for cluster role and cluster role binding formatting #39
+99
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Great work, thanks a lot @addyess. LGTM overall, just a minor question.
addyess
force-pushed
the
KU-2645/add-resource-name-posfix
branch
from
765d267 to
c245367
Compare
|
Converting to draft to resolve conflicts in RBD and XFS storage class names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a formatter to prevent conflicts in names of non-namespaced objects in ClusterRole and ClusterRoleBindings
In order to deploy N ceph-csi charm applications into a model, we need to prepare the Kubernetes resources to have different names so they do not collide with one another. While the charm can detect collisions, it can't work around them.
This change allows some "non-namespaced" resources in the cluster to support a format-able name -- specifically the RBAC controls. I'd be willing to discuss a better name for the charm config.
the following may not be the clearest name:
There are really on a few Kubernetes resources that collide (because they aren't namespace scoped resources)
ClusterRoleClusterRoleBindingStorageClassThe storage-classes have been resolved with their own formatters, so all that remains is supporting a rename of
ClusterRoleandClusterRoleBinding.