chore: changed publishing approach #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1323 +/- ##
========================================
Coverage 73.76% 73.76%
========================================
Files 42 42
Lines 1231 1231
Branches 322 322
========================================
Hits 908 908
Misses 239 239
Partials 84 84 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@gionkunz Hi. Webpack should receive ESM treeshakable bundle , but now it will use iife bundle from browser field. Also it's not UMD bundle but named like that. UMD bundle builds for main field (you can see it in Rollup config). I sugges you to revert this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read through webpack/webpack#4674 and changed the publishing approach accordingly.