Enable scale title stroke (12092)

[asmenezes]

Added Stroke Color and Width to Cartesian scale options, and pass them to drawTitle() so they can be used on the titles for Cartesian scales

Example: https://codepen.io/asmenezes/pen/zxrzaEx

[LeeLenaleee]

Can you also add a test for this?

[asmenezes]

Can you also add a test for this?

Added an image based test. Let me know if that's not the appropriate way to do it.

[etimberg]

@asmenezes TBH, not sure if an image based test works here. We have a way of spriting text during tests to handle browser inconsistencies so I suspect it doesn't actually exercise the stroke code

[asmenezes]

@etimberg Thanks for the info. I have been thinking about this and I am not sure if I can think of any other way to test that the stroke has actually been drawn.

I did consider a test similar to the many that resolve like the example below.

  var scale = chart.scales.x;
  expect(getLabels(scale)).toEqual(labels.slice(1));

However I don't know if that tests if the stroke color and width were actually used, or if they were just added as properties.

Do you know if that sort of test is sufficient or I should find another way to do it?

Thanks.

[etimberg]

@asmenezes I think that test would be sufficient here

[asmenezes]

@etimberg Thanks.

The merge-base changed after approval.

The merge-base changed after approval.

The merge-base changed after approval.

The merge-base changed after approval.

[LeeLenaleee]

@asmenezes it seems like something is not working right, it automatically dismisses reviews.
Can you try pulling in the latest master, since some of your changes are the same as currently in master to see if that fixes the issue.

[asmenezes]

@LeeLenaleee should be all synced up now