fix(core): isolate scheduled prompt sessions by default - #1496
Closed
AaronZ345 wants to merge 2 commits into
Closed
Conversation
AaronZ345
force-pushed
the
fix/cron-busy-side-session-20260705
branch
2 times, most recently
from
July 8, 2026 14:40
2e45d4a to
4c7508d
Compare
AaronZ345
force-pushed
the
fix/cron-busy-side-session-20260705
branch
2 times, most recently
from
July 14, 2026 03:05
7e64047 to
bc0a37f
Compare
Contributor
Author
|
Hi @chenhg5, I’ve rebased this PR onto the latest main and all five CI checks are green. Could you please take another look and merge it when you have a chance? Thanks! |
AaronZ345
force-pushed
the
fix/cron-busy-side-session-20260705
branch
2 times, most recently
from
July 19, 2026 14:44
7a41bfc to
e409299
Compare
AaronZ345
force-pushed
the
fix/cron-busy-side-session-20260705
branch
from
July 23, 2026 14:44
e409299 to
3bca008
Compare
AaronZ345
force-pushed
the
fix/cron-busy-side-session-20260705
branch
from
July 25, 2026 14:41
3bca008 to
56a11a5
Compare
Contributor
Author
|
Superseded by #1651, which carries the same patch rebased onto the latest main on a fresh branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_mode = "reuse"or--session-mode reuseis set explicitly.Root cause
Scheduled prompt jobs inherited the active chat session by default. When a cron fired while the user session was already busy, it could fail with a busy-session error or wait behind unrelated interactive work. The scheduled task should be isolated by default instead of competing with normal chat turns.
Test Plan
go test -count=1 ./core ./configGOOS=linux GOARCH=amd64 go test -c -tags no_web ./cmd/cc-connectgit diff --checkSupersedes #1349. This is the same rebased patch on a fresh PR branch.