Feat telescope support to list marks#106
Open
ValJed wants to merge 11 commits intochentoast:masterfrom
Open
Conversation
|
this is great - is it possible to list bookmarks as well? |
Author
|
@ctorney I'm not familiar with bookmarks, but should be doable I suppose. |
ba9d003 to
0fe9ed8
Compare
28797af to
8af9bae
Compare
8af9bae to
e0f3229
Compare
ValJed
commented
Mar 5, 2024
|
|
||
| return items | ||
| end | ||
|
|
Author
There was a problem hiding this comment.
Real changes are only in this hunk, rest is linting.
Author
|
@ctorney Done it now also supports bookmarks listing. See readme. |
|
Thanks @ValJed! Works perfectly |
tylerw
added a commit
to tylerw/marks.nvim
that referenced
this pull request
Oct 21, 2024
|
I wonder when this pull request is merged into master? |
I'm also wondering the same thing. |
Author
|
Me too ahah. @dangkhoipro @pidgeon777 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋🏼
I was a bit frustrated when searching in my existing marks (I often lose myself). So I thought that a telescope extension would be a perfect fit for that (fuzzy finding, location preview).
I added two methods that return the right data for buffer marks and project marks as well as two telescope extensions that allow to get the current buffer marks and the project marks.
It looks like this for the buffer one:
And like this for the list all marks:
I named the extension
marks_nvimbecause I had weird errors withmarksthat could be linked to possible conflicts.Anyway, I hope it'll be useful to some and tanks for the great plugin!