Add option to disable floating preview window#121
Open
eilefsen wants to merge 1 commit intochentoast:masterfrom
Open
Add option to disable floating preview window#121eilefsen wants to merge 1 commit intochentoast:masterfrom
eilefsen wants to merge 1 commit intochentoast:masterfrom
Conversation
if `config.float` is set to false in the setup function, we use neovim's built-in 'preview window' (see `:h preview-window`) instead of opening our own floating window. The floating window is still opened by default, but it is now optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if
config.floatis set to false in the setup function, we use neovim's built-in 'preview window' (see:h preview-window) instead of opening our own floating window.The floating window is still used by default, but it is now optional.
Using the preview-window fits my style of managing windows and tabpages better, which is why i wanted this option. I'm quite happy with it so i figured i might as well share the code upstream :)
I'm a bit unsure if requiring 'marks' from 'marks.mark' is a perfectly good idea (i'm not very familiar with lua modules), but it seemed necessary in order to use the option.
floatmight also not be the most descriptive name for the option, feel free to change it. :)If this PR gets attention I can of course also contribute the necessary documentation.