Skip to content

fix: disable display-signs on floating windows#99

Open
triarius wants to merge 1 commit intochentoast:masterfrom
triarius:disable-on-floating
Open

fix: disable display-signs on floating windows#99
triarius wants to merge 1 commit intochentoast:masterfrom
triarius:disable-on-floating

Conversation

@triarius
Copy link

@triarius triarius commented Nov 25, 2023

The filetype exclusions are not the best way to disable the mark signs on certain windows as the filetype is a property of the buffer, while floating is a property of the window. The same filetype could be displayed differently depending on whether its window is floating or not. I think most users are unlikely to want these in floating windows, so I disabled them entirely. I'd be happy to make this configurable, but I think the default should be that they are not shown, as typically the normal editing workflow does not apply to floating windows.

In my case, they appear in LSP hints, which are not intended to hold a cursor. It also makes the content no longer fit in the window.

Fixes: #60

Screenshots for LSP

Before

2023-11-25-17-46-48

After

2023-11-25-17-46-10

Screenshots for Neo Tree

Ignore the line numbers, they are caused by a different plugin.

Before

2023-11-25-17-08-44

After

2023-11-25-17-09-23

@ofseed
Copy link
Contributor

ofseed commented Jan 4, 2024

I found this PR just now. I have the same problem and made this #101

@Charlie-83
Copy link

I was having the same problem with LazyGit. This commit fixes it for me

@chentoast
Copy link
Owner

I didn't like the proposal of blanket disabling mark displays on floating windows. I think that using the fix proposed in #101 presents a better and more configurable alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

excluded_filetypes does not exclude floating windows made by nui ?

4 participants