fix: disable display-signs on floating windows#99
Open
triarius wants to merge 1 commit intochentoast:masterfrom
Open
fix: disable display-signs on floating windows#99triarius wants to merge 1 commit intochentoast:masterfrom
triarius wants to merge 1 commit intochentoast:masterfrom
Conversation
Contributor
|
I found this PR just now. I have the same problem and made this #101 |
|
I was having the same problem with LazyGit. This commit fixes it for me |
Owner
|
I didn't like the proposal of blanket disabling mark displays on floating windows. I think that using the fix proposed in #101 presents a better and more configurable alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filetype exclusions are not the best way to disable the mark signs on certain windows as the filetype is a property of the buffer, while floating is a property of the window. The same filetype could be displayed differently depending on whether its window is floating or not. I think most users are unlikely to want these in floating windows, so I disabled them entirely. I'd be happy to make this configurable, but I think the default should be that they are not shown, as typically the normal editing workflow does not apply to floating windows.
In my case, they appear in LSP hints, which are not intended to hold a cursor. It also makes the content no longer fit in the window.
Fixes: #60
Screenshots for LSP
Before
After
Screenshots for Neo Tree
Ignore the line numbers, they are caused by a different plugin.
Before
After