QP-8393 Fix wrong StopIndex on emitDot #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
evan-choi
approved these changes
Apr 29, 2024
Web-Engine
added a commit
that referenced
this pull request
Apr 29, 2024
MySQL Lex 과정에서, emitDot (앞에 붙은 .을 별도 토큰으로 분리) 할 때 identifier의 StopIndex가 잘못 설정되는 문제를 해결합니다. 이를 통해 다음과 같은 쿼리의 InfferedName이 잘못 추론되지 않도록 수정합니다. ```sql SELECT @@GLOBAL.character_set_server,@@GLOBAL.collation_server; -- old inffered name: -- @@GLOBAL.character_set_server, // (뒤에 ,가 붙음) -- @@GLOBAL.collation_server -- new inferred name: -- @@GLOBAL.character_set_server -- @@GLOBAL.collation_server ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL Lex 과정에서, emitDot (앞에 붙은 .을 별도 토큰으로 분리) 할 때
identifier의 StopIndex가 잘못 설정되는 문제를 해결합니다.
이를 통해 다음과 같은 쿼리의 InfferedName이 잘못 추론되지 않도록 수정합니다.