Repository navigation
feat(watch-pr): hold READY until review activity settles - #3
Merged
Merged
Conversation
READY now waits until accounts other than the PR author and the gh viewer have been quiet on the PR for --settle seconds (default 300). The window starts at the latest of the head's push, the PR's opening, and its last ready for review. An eyes reaction holds it up to 30 minutes after that start. The push time comes from GitHub's repository activity log, not commit dates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The commonest babysitting failure in an audit of agent history (about 121 of 227 flaw instances) was calling a PR ready once CI turned green, before review bots had posted.
watch-prknew only Bugbot. This adds a review settle window that names no bot.What changed
watch-pr --settle <seconds>(default 300,0off) holds READY until accounts other than the PR author and theghviewer have been quiet on the PR for that long. The window starts at the latest of the head's push, the PR's opening, and its last ready for review. Aneyesreaction holds READY up to 30 minutes after that start.review-settling, and--status-onlyshows the time left.t3-tools.mdsays the standalonebabysitskill's own polling is replaced on T3, and that no per-bot rules are needed.Scope
--stackwatches. Queued mode does not settle.Blast Radius
Every READY from
watch-prnow waits at least until the window ends. The draft, review-required, and branch-protection gates also wait for it. The logic lives in the new port-onlysettle.ts. The upstream watcher files carry small hooks, listed in the 1.0.5 CHANGES entry for the next pstack-claude merge.Verification
generate --check, the fork dry-run, and the sheet checker pass.