Fill missing data with NaNs in validation plots #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljgray
force-pushed
the
ljg/assorted-fixes
branch
from
4c8221d to
58af561
Compare
ketiltrout
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plt.imshowdoesn't have a concept of missing samples along an axis. For time-sampled data, we instead have to create a regular grid and display the time-sampled data on that grid, with NaNs in place of missing samples. This fixes the issue where highlighted sources were sometimes misaligned.Also, include date and time information in the title for each CSD.
Seems to work, although it's always possible that there are some edge cases I've missed.