Skip to content

Added SDVOL pullup control and definition #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majenkotech wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added SDVOL pullup control and definition #450

majenkotech wants to merge 2 commits into from

Conversation

@majenkotech
Copy link
Member

@majenkotech majenkotech commented Mar 14, 2019

Also fixed the chip select pin number for the WiFire.

The theory here is quite simple:

  • SDVOL was changed some time back to take a chip select pin instead of a pullup pin (for obvious reasons)
  • No facility for controlling the pullup pin was retained
  • This puts that facility back in using a simple #define in the board definition

@majenkotech majenkotech mentioned this pull request Mar 14, 2019
Open
@majenkotech
Copy link
Member Author

majenkotech commented Mar 14, 2019

Also fixed the WF32 definitions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@majenkotech