rust-clippy #157
chipnertkjrust-clippy.yml
on: schedule
Run rust-clippy analysis
50s
Annotations
16 warnings
|
Run rust-clippy analysis
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy@master. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Run rust-clippy analysis
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy@master. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run rust-clippy analysis
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run rust-clippy analysis
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run rust-clippy analysis
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run rust-clippy analysis
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Run rust-clippy analysis:
common/src/settings/theme/font_families/family/generic.rs#L79
warning: unneeded `return` statement
--> common/src/settings/theme/font_families/family/generic.rs:79:13
|
79 | / return Err(cssparser::ParseError {
80 | | kind: cssparser::ParseErrorKind::Basic(
81 | | cssparser::BasicParseErrorKind::UnexpectedToken(
82 | | token.to_owned(),
... |
85 | | location: parser.current_source_location(),
86 | | });
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
79 ~ Err(cssparser::ParseError {
80 + kind: cssparser::ParseErrorKind::Basic(
81 + cssparser::BasicParseErrorKind::UnexpectedToken(
82 + token.to_owned(),
83 + ),
84 + ),
85 + location: parser.current_source_location(),
86 ~ })
|
|
|
Run rust-clippy analysis:
glue/src/invoke.rs#L27
warning: doc list item without indentation
--> glue/src/invoke.rs:27:5
|
27 | /// match that of the specified backend command. This also applies if the
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
27 | /// match that of the specified backend command. This also applies if the
| ++
|
|
Run rust-clippy analysis:
glue/src/invoke.rs#L28
warning: doc list item without indentation
--> glue/src/invoke.rs:28:5
|
28 | /// command natively returns a `Result`.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
28 | /// command natively returns a `Result`.
| ++
|
|
Run rust-clippy analysis:
glue/src/invoke.rs#L29
warning: doc list item without indentation
--> glue/src/invoke.rs:29:5
|
29 | /// `invoke` returns a JS Promise error if the command does not exist.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
29 | /// `invoke` returns a JS Promise error if the command does not exist.
| ++
|
|
Run rust-clippy analysis:
glue/src/invoke.rs#L57
warning: doc list item without indentation
--> glue/src/invoke.rs:57:5
|
57 | /// match that of the specified backend command.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
57 | /// match that of the specified backend command.
| ++
|
|
Run rust-clippy analysis:
ui/app/src/lib.rs#L2
warning: the feature `const_mut_refs` has been stable since 1.83.0 and no longer requires an attribute to enable
--> ui/app/src/lib.rs:2:12
|
2 | #![feature(const_mut_refs)]
| ^^^^^^^^^^^^^^
|
= note: `#[warn(stable_features)]` on by default
|
|
Run rust-clippy analysis:
ui/app/src/app/editor.rs#L14
warning: unused variable: `props`
--> ui/app/src/app/editor.rs:14:22
|
14 | pub(super) fn Editor(props: &Props) -> yew::Html {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_props`
|
= note: `#[warn(unused_variables)]` on by default
|
|
Run rust-clippy analysis:
ui/app/src/app.rs#L49
warning: unused variable: `app_state`
--> ui/app/src/app.rs:49:28
|
49 | fn query_backend_app_state(app_state: UseStateHandle<AppState>) {
| ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_app_state`
|
|
Run rust-clippy analysis:
ui/app/src/app/backend_query.rs#L5
warning: variant `QuerySettings` is never constructed
--> ui/app/src/app/backend_query.rs:9:5
|
5 | pub(super) enum BackendQueryState {
| ----------------- variant in this enum
...
9 | QuerySettings,
| ^^^^^^^^^^^^^
|
= note: `BackendQueryState` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
Run rust-clippy analysis:
ui/app/src/app/home.rs#L22
warning: function `html_querying_settings` is never used
--> ui/app/src/app/home.rs:22:4
|
22 | fn html_querying_settings() -> yew::Html {
| ^^^^^^^^^^^^^^^^^^^^^^
|