absolutize() should return error for ambiguous paths#63
Merged
Conversation
dlenski
force-pushed
the
absolutize_failure
branch
from
dafe463 to
18185f7
Compare
This addresses the "silent failure" piece of chipsenkbeil#61, and adds specific test cases: - `C:something`: ambiguous because Windows maintains a per-disk cwd as a relic of MS-DOS, but only in certain contexts. (In others, this is treated as equivalent to `C:\something`.) - `\\server`: this isn't a complete path. Without adding `\share` on the end, it can't be used in most contexts where Windows would allow a directory path; it should probably be `!is_valid()` as well as `!is_absolute()`.
dlenski
force-pushed
the
absolutize_failure
branch
from
18185f7 to
453a824
Compare
(Could bump to 1.74 and omit this commit)
Owner
|
Looks good to me. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the "silent failure" piece of #61, and adds specific test cases:
C:something: ambiguous because Windows maintains a per-disk cwd as a relic of MS-DOS, but only in certain contexts. (In others, this is treated as equivalent toC:\something.)\\server: this isn't a complete path. Without adding\shareon the end, it can't be used in most contexts where Windows would allow a directory path; it should probably be!is_valid()as well as!is_absolute().