Migrate products and events to design-system-base layout#1396
Merged
stefan-burke merged 7 commits intomainfrom May 5, 2026
Merged
Migrate products and events to design-system-base layout#1396stefan-burke merged 7 commits intomainfrom
stefan-burke merged 7 commits intomainfrom
Conversation
Replaces _layouts/item.html with design-system-base.html plus new product-*, event-*, and shared item-* blocks. Each product/event uses product-intro/outro and event-intro/outro snippets so common block sequences are defined once and reused across the collection. New blocks (and per-collection allowlists): - product-header / event-header (shared item-header-block.html) - product-gallery / event-gallery (shared item-gallery-block.html) - product-/event-/property-contact-section (shared item-contact-section-block.html) - product-meta, event-meta (reuse new _item-rating-paragraph.html and _item-categories-paragraph.html) - hire-pricing, purchase-link, product-tabs, product-add-ons, product-features, product-specs - event-products, event-map Removes the now-orphaned item.html layout and its includes (item-event-*, item-reviews-*, item-map-section, tabs.html).
product-features, product-specs, hire-pricing, and purchase-link are now sugar blocks: each maps page data to the canonical design-system block shape (icon-links, features, stats, link-button respectively) via new computed properties on products.11tydata.js, then delegates to the design-system template. Drops the ad-hoc CSS classes (feature-card list, specs-grid, hire-prices, purchase-button) and removes the orphaned partials. product-add-ons keeps its bespoke add-on-card rendering but loses its redundant `<div class="design-system">` wrapper (the layout already sets that on <body>). Extends features/stats/link-button to accept their items/text/href parameters directly so sugar blocks don't need to construct a `block` object literal in Liquid (LiquidJS doesn't expand object literals as include arguments). Pattern matches the existing icon-links partial.
Single `tabs` block allowed on products, events, and properties — all three render the same `tabs` data via tabs-inner.html, so there's no reason to duplicate the schema. The property-specific `.property-tabs` SCSS block is gone too; the global `#tabs` styles in tabs.scss handle both contexts. Updates the three property markdown files and the product-intro snippet to reference `tabs` instead of the old type names.
…ts-design-system-zpnDB # Conflicts: # .pages.yml # BLOCKS_LAYOUT.md # src/_includes/design-system/blocks/property-contact-section.html # src/_includes/design-system/blocks/property-tabs.html # src/_includes/design-system/render-block.html # src/_layouts/item.html # src/_lib/utils/block-schema/property-contact-section.js # src/_lib/utils/block-schema/property-tabs.js # test/integration/eleventy/product-ordering.test.js # test/integration/eleventy/search.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_layouts/item.html(now deleted) withdesign-system-base.htmlfor products and events.*, event-*, and shared item-*blocks that mirror the originalitem.htmlstructure: header, gallery, meta, hire-pricing, purchase-link, tabs, add-ons, features, specs, contact-section, plus event-onlyevent-productsandevent-map.product-intro+product-outro(orevent-intro+event-outro) snippets so the long common block sequences are defined once and reused across the collection — this also gives template users a worked example of the snippet system.Test plan
bun run buildproduces all 14 product pages, all 5 event pages, and the existing property/news/category pagesbun test(full suite) passes — 2968 / 2968category-products,product-ordering, andsearchintegration tests so test fixtures author body content asmarkdownblocks (required under design-system-base)BLOCKS_LAYOUT.mdand.pages.ymlhttps://claude.ai/code/session_01GXHrZrqLKNrqNhPeLeRHet
Generated by Claude Code